[PATCH v5 2/2] tpm-v2: allow algorithm name to be configured for pcr_read and pcr_extend

[Ilias Apalodimas]

On Mon, 27 May 2024 at 14:48, Miquel Raynal <miquel.raynal at bootlin.com> wrote:
>
> Hi Ilias,
>
> ilias.apalodimas at linaro.org wrote on Mon, 27 May 2024 12:44:11 +0300:
>
> > Hi Miquel
> >
> > On Mon, 27 May 2024 at 11:59, Miquel Raynal <miquel.raynal at bootlin.com> wrote:
> > >
> > > Hi Tim,
> > >
> > > tharvey at gateworks.com wrote on Sat, 25 May 2024 13:00:49 -0700:
> > >
> > > > For pcr_read and pcr_extend commands allow the digest algorithm to be
> > > > specified by an additional argument. If not specified it will default to
> > > > SHA256 for backwards compatibility.
> > > >
> > > > Additionally update test_tpm2.py for the changes in output in pcr_read
> > > > which now shows the algo and algo length in the output.
> > > >
> > > > A follow-on to this could be to extend all PCR banks with the detected
> > > > algo when the <digest_algo> argument is 'auto'.
> > > >
> > > > Signed-off-by: Tim Harvey <tharvey at gateworks.com>
> > > > Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>
> > >
> > > LGTM,
> > >
> > > Reviewed-by: Miquel Raynal <miquel.raynal at bootlin.com>
> >
> > Thanks for taking the time, unfortunately I've already queued these
> > for Tom and your r-b is missing
>
> Maybe it's not a big deal to force push your branch?

I've replied to that PR, hopefully Tom will see it before merging

> Otherwise please
> consider letting a bit more time to the reviewers next time. 2 days
> over the weekend is definitely not enough if you refuse to update your
> branch.

I usually do, but the patch is on v5 and had no comments apart from
mine for > ~1 month

Thanks
/Ilias

>
> Thanks,
> Miquèl