[PATCH v3 7/7] board: rockchip: add ArmSoM Sige7 Rk3588 board

[Jonas Karlman]

Hi Jianfeng,

On 2024-05-27 19:02, Jianfeng Liu wrote:
> ArmSoM Sige7 is a Rockchip RK3588 based SBC (Single Board Computer) by
> ArmSoM.
> 
> There are two variants depending on the DRAM size : 8G and 16G.
> 
> Specification:
> 
>     Rockchip Rk3588 SoC
>     4x ARM Cortex-A76, 4x ARM Cortex-A55
>     8/16GB memory LPDDR4x
>     Mali G610MC4 GPU
>     2x MIPI CSI 2 multiple lanes connector
>     64GB/128GB on board eMMC
>     uSD slot
>     1x USB 2.0 Type-A, 1x USB 3.0 Type-A, 1x USB 3.0 Type-C
>     1x HDMI 2.1 output
>     2x 2.5 Gbps Ethernet port
>     40-pin IO header including UART, SPI and I2C
>     USB PD over USB Type-C
>     Size: 92mm x 62mm
> 
> Kernel commit:
> 81c828a67c78 (arm64: dts: rockchip: Add ArmSom Sige7 board)
> 
> Signed-off-by: Jianfeng Liu <liujianfeng1994 at gmail.com>
> ---
> 
> Changes in v3:
> - Use update-dts-subtree.sh to pick upstream dts
> 
> Changes in v2:
> - Fix alphabetical order of MAINTAINERS
> - Use arch/arm/dts/rk3588-armsom-sige7* in board MAINTAINERS
> - Remove spi flash related config
> - Move kernel dts to dts/upstream/src/arm64/rockchip/
> 
>  MAINTAINERS                                  |  1 +
>  arch/arm/dts/rk3588-armsom-sige7-u-boot.dtsi | 28 ++++++
>  arch/arm/mach-rockchip/rk3588/Kconfig        | 26 ++++++
>  board/armsom/sige7-rk3588/Kconfig            | 12 +++
>  board/armsom/sige7-rk3588/MAINTAINERS        |  7 ++
>  configs/sige7-rk3588_defconfig               | 93 ++++++++++++++++++++
>  doc/board/rockchip/rockchip.rst              |  1 +
>  include/configs/sige7-rk3588.h               | 15 ++++
>  8 files changed, 183 insertions(+)
>  create mode 100644 arch/arm/dts/rk3588-armsom-sige7-u-boot.dtsi
>  create mode 100644 board/armsom/sige7-rk3588/Kconfig
>  create mode 100644 board/armsom/sige7-rk3588/MAINTAINERS
>  create mode 100644 configs/sige7-rk3588_defconfig
>  create mode 100644 include/configs/sige7-rk3588.h
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6c861b529df..fffcf898bf1 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -534,6 +534,7 @@ F:	arch/arm/include/asm/arch-rockchip/
>  F:	arch/arm/mach-rockchip/
>  F:	board/amarula/vyasa-rk3288/
>  F:	board/anbernic/rgxx3_rk3566/
> +F:	board/armsom/sige7-rk3588/
>  F:	board/chipspark/popmetal_rk3288
>  F:	board/engicam/px30_core/
>  F:	board/firefly/
> diff --git a/arch/arm/dts/rk3588-armsom-sige7-u-boot.dtsi b/arch/arm/dts/rk3588-armsom-sige7-u-boot.dtsi
> new file mode 100644
> index 00000000000..2c984d01471
> --- /dev/null
> +++ b/arch/arm/dts/rk3588-armsom-sige7-u-boot.dtsi
> @@ -0,0 +1,28 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2024 ArmSoM Technology Co., Ltd.
> + */
> +
> +#include "rk3588-u-boot.dtsi"
> +
> +&sdhci {
> +	cap-mmc-highspeed;
> +	mmc-hs200-1_8v;
> +};

The sdhci node should not be needed, mmc-hs200-1_8v is already defined
in the upstream DT and cap-mmc-highspeed modes only work if HS200 can
first be initialized.

> +
> +&u2phy1 {
> +	status = "okay";
> +};
> +
> +&u2phy1_otg {
> +	status = "okay";
> +};
> +
> +&usbdp_phy1 {
> +	status = "okay";
> +};
> +
> +&usb_host1_xhci {
> +	dr_mode = "host";
> +	status = "okay";
> +};

These usb related nodes is already defined in main DT, please remove.

Regards,
Jonas

[snip]