[PATCH 1/5] pinctrl: qcom: add support for bias-pull-down

[Sumit Garg]

Hi Neil,

On Tue, 28 May 2024 at 14:02, Neil Armstrong <neil.armstrong at linaro.org> wrote:
>
> Add support for bias-pull-down as an alternate of bias-pull-up.

nit: s/alternate/alternative/

>
> Signed-off-by: Neil Armstrong <neil.armstrong at linaro.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-qcom.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-qcom.c b/drivers/pinctrl/qcom/pinctrl-qcom.c
> index 3c3336e7635..4f4e9a83949 100644
> --- a/drivers/pinctrl/qcom/pinctrl-qcom.c
> +++ b/drivers/pinctrl/qcom/pinctrl-qcom.c
> @@ -44,6 +44,7 @@ static const struct pinconf_param msm_conf_params[] = {
>         { "drive-strength", PIN_CONFIG_DRIVE_STRENGTH, 2 },
>         { "bias-disable", PIN_CONFIG_BIAS_DISABLE, 0 },
>         { "bias-pull-up", PIN_CONFIG_BIAS_PULL_UP, 3 },
> +       { "bias-pull-down", PIN_CONFIG_BIAS_PULL_UP, 1 },

Did you mean PIN_CONFIG_BIAS_PULL_DOWN here instead?

-Sumit

>         { "output-high", PIN_CONFIG_OUTPUT, 1, },
>         { "output-low", PIN_CONFIG_OUTPUT, 0, },
>  };
>
> --
> 2.34.1
>