[PATCH v2 6/7] tools: add genguid tool

[Caleb Connolly]

Hi Simon,

On 29/05/2024 21:45, Simon Glass wrote:
> Hi Caleb,
> 
> On Wed, 29 May 2024 at 13:02, Caleb Connolly <caleb.connolly at linaro.org> wrote:
>>
>> Hi Simon,
>>
>> On 29/05/2024 18:30, Simon Glass wrote:
>>> Hi Caleb,
>>>
>>> On Wed, 29 May 2024 at 08:49, Caleb Connolly <caleb.connolly at linaro.org> wrote:
>>>>
>>>> Add a tool that can generate GUIDs that match those generated internally
>>>> by U-Boot for capsule update fw_images.
>>>>
>>>> Dynamic UUIDs in U-Boot work by taking a namespace UUID and hashing it
>>>> with the board model, compatible, and fw_image name.
>>>>
>>>> This tool accepts the same inputs and will produce the same GUID as
>>>> U-Boot would at runtime.
>>>>
>>>> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>
>>>> ---
>>>>    tools/Makefile  |   3 ++
>>>>    tools/genguid.c | 154 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>>    2 files changed, 157 insertions(+)
>>>
>>> Where is this tool used? Can you add a man page and test?
>>
>> It currently doesn't have any users, it just allows for pre-generating
>> GUIDs ahead of time for a given board. It might be hooked up to vendor
>> tooling or some usecase like that.
>>
>> I've somehow escaped learning Groff before now heh, I can give it a go
>> and write a test.
> 
> OK (just copy bits of mkimage.1 :-)

Right :D
> 
> Re the test, would this be something that binman would use? If so you
> could put a test there.

This tool is just a wrapper for gen_uuid_v5() which we already test in 
the dynamic UUID unit tests also introduced in this series. I don't 
think it's necessary to additionally test this tool.

Kind regards,
> 
> Regards,
> Simon

-- 
// Caleb (they/them)