[PATCH 1/1] test: cmd/mbr: pass correct buffer size to init_write_buffers

Heinrich Schuchardt heinrich.schuchardt at canonical.com
Sat Nov 2 16:41:30 CET 2024


We want to completely initialize the mbr and embr buffers. This requires
passing the buffer size and not the size of a pointer to the buffer.

Addresses-Coverity-ID: 510454 Wrong sizeof argument
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
---
 test/cmd/mbr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/cmd/mbr.c b/test/cmd/mbr.c
index b14137e589a..16a8bc39e7e 100644
--- a/test/cmd/mbr.c
+++ b/test/cmd/mbr.c
@@ -277,7 +277,7 @@ static int mbr_test_run(struct unit_test_state *uts)
 				 (ulong)0xbffe00 / BLKSZ));
 
 	/* Test one MBR partition */
-	init_write_buffers(mbr_wbuf, sizeof(mbr_wbuf), ebr_wbuf, sizeof(ebr_wbuf), __LINE__);
+	init_write_buffers(mbr_wbuf, BLKSZ, ebr_wbuf, BLKSZ, __LINE__);
 	ut_assertok(build_mbr_parts(mbr_parts_buf, sizeof(mbr_parts_buf), 1));
 	ut_assertok(run_commandf("write mmc 6:0 %lx 0 1", mbr_wa));
 	memset(rbuf, '\0', BLKSZ);
-- 
2.45.2



More information about the U-Boot mailing list