[PATCH 1/3] board: phytec: phycore-imx93: Add 2GB LPDDR4X RAM timings

Fabio Estevam festevam at gmail.com
Mon Nov 4 13:30:23 CET 2024


Hi Christoph,

On Mon, Nov 4, 2024 at 7:52 AM Christoph Stoidner <c.stoidner at phytec.de> wrote:
>
> The phyCORE-i.MX 93 is available with a 1GB ram chip or a 2GB ram chip.
> Add the ram timings for the 2GB chip, in form of a diff compared
> to the existing LPDDR4X 1GB timings. With that, the SPL can select the
> appropriate timings at startup.
>
> Signed-off-by: Christoph Stoidner <c.stoidner at phytec.de>
> Cc: Mathieu Othacehe <m.othacehe at gmail.com>, Christoph Stoidner <c.stoidner at phytec.de>, Tom Rini <trini at konsulko.com>, Yannic Moog <y.moog at phytec.de>, Primoz Fiser <primoz.fiser at norik.com>, Andrej Picej <andrej.picej at norik.com>, Wadim Egorov <w.egorov at phytec.de>

As Teresa pointed out, the correct way to add Cc is as follows:

Cc: Mathieu Othacehe <m.othacehe at gmail.com>
Cc: Christoph Stoidner <c.stoidner at phytec.de>
... etc

You can even put the Cc list below the --- line so it does not appear
in the commit log.

Please run checkpatch on all the patches too. There is a warning on
this one that is easy to fix:

./scripts/checkpatch.pl
~/Downloads/1-3-board-phytec-phycore-imx93-Add-2GB-LPDDR4X-RAM-timings.patch
CHECK: Please don't use multiple blank lines
#879: FILE: board/phytec/phycore_imx93/lpddr4_timing.c:1350:

+

total: 0 errors, 0 warnings, 1 checks, 1051 lines checked


More information about the U-Boot mailing list