[PATCH v12 00/13] net: tcp: improve tcp support in legacy stack

[Simon Glass]

Hi Tom,

On Mon, 4 Nov 2024 at 16:32, Tom Rini <trini at konsulko.com> wrote:
>
> On Mon, Oct 28, 2024 at 05:31:30PM +0300, Mikhail Kshevetskiy wrote:
>
> > Legacy TCP stack is bad. Here are some of the known issues:
> >  * tcp packet from other connection can break a current one
> >  * tcp send sequence always starts from zero
> >  * bad tcp options processing
> >  * strange assumptions on packet size for selective acknowledge
> >  * tcp interface assumes one of the two scenarios:
> >      - data downloading from remote host to a board
> >      - request-response exchange with a small packets
> >    so it's not possible to upload large amount of data from the
> >    board to remote host.
> >  * wget test generate bad tcp stream, test should fail but it passes instead
> >
> > This series of patches fixes all of the above issues.
>
> I know Peter asked on the last one, but I want to ask as well. With lwIP
> merged, why do we want to add features to the old stack? I can see
> fixing issues, but not adding new functionality as well. Thanks.
>

Let's apply this. It has tests and the old stack is still used by a
lot of boards. At present lwip is only used on one. There is more work
to do on the new stack, including finishing off the sandbox
implementation.

Regards,
Simon