[PATCH v3 00/25] led: Remove old status-LED code

[Peter Robinson]

On Sun, 3 Nov 2024 at 00:34, Simon Glass <sjg at chromium.org> wrote:
>
> There has been an LED framework in U-Boot which uses driver model for
> about 9 years now. Recent work is underway to improve it and provide
> more features. It is probably a good time to drop the old code, which
> is only used by 5 boards:

I don't believe, from what I can tell, they are feature comparable, at
the very least I have not been able to get the Pinephone working with
this so as it stands I still don't think this patch set is ready yet.

>    ./tools/qconfig.py -f LED_STATUS
>    5 matches
>    eb_cpu5282 eb_cpu5282_internal mx23_olinuxino pinephone
>    socfpga_vining_fpga
>
> This series attempts that.
>
> The new /options node provides a way to provide U-Boot settings, and
> LEDs are implemented there. For now I have brought into the options
> schema from upstream. We can update it once the LED additions land
> there.
>
> Changes in v3:
> - Update commit message
> - Combine removal and enable patches
> - Combine removal and enable patches
> - Combine removal and enable patches
>
> Changes in v2:
> - Combine code-removal and defconfig changes
> - Add a patch to enable LED and LED_BOOT for these boards
> - Enable LED on the 5 affected platforms
> - Reorder patches for bisectability
> - Add dt-schema bindings for LED
>
> Simon Glass (25):
>   eb_cpu5282: Drop status-LED code and enable LED
>   vining_fpga: Drop status-LED code and use LED
>   mx23_olinuxino: Drop status-LED code and use LED
>   pinephone: Drop status-LED code and use LED
>   led: Drop LED_STATUS_BOARD_SPECIFIC
>   arm: Drop old LED support
>   common: doc: Drop old LED support
>   st: stm32f429: Drop old LED code
>   led: Make the LED config common
>   led: Drop LED_STATUS from Kconfig
>   led: Drop the legacy LED command
>   misc: Drop gpio_led driver
>   pca9551_led: Delete driver
>   misc: status_led: Delete driver
>   m68k: Drop unused status_led.h header file
>   powerpc: Drop status-LED code
>   igep00x0: Drop unused status_led.h header file
>   sunxi: Drop status-LED code
>   common: Drop status-LED code in board_r
>   image: Drop unused status_led.h header file
>   ide: Drop unused status_led.h header file
>   mpc83xx: Drop status-LED code
>   net: Drop status-LED code
>   led: Drop status_led header file
>   doc: Add devicetree bindings for options
>
>  arch/arm/lib/crt0.S                          |   4 -
>  arch/m68k/lib/bootm.c                        |   3 -
>  arch/powerpc/lib/interrupts.c                |   6 -
>  board/BuS/eb_cpu5282/eb_cpu5282.c            |  20 --
>  board/isee/igep00x0/igep00x0.c               |   1 -
>  board/olimex/mx23_olinuxino/mx23_olinuxino.c |   7 -
>  board/softing/vining_fpga/socfpga.c          |   4 -
>  board/st/stm32f429-discovery/Makefile        |   1 -
>  board/st/stm32f429-discovery/led.c           |  39 ---
>  board/sunxi/board.c                          |   6 -
>  boot/image.c                                 |   4 -
>  cmd/Makefile                                 |   1 -
>  cmd/ide.c                                    |   4 -
>  cmd/legacy_led.c                             | 185 ----------
>  common/board_f.c                             |  22 --
>  common/board_r.c                             |  27 --
>  configs/eb_cpu5282_defconfig                 |   8 +-
>  configs/eb_cpu5282_internal_defconfig        |   8 +-
>  configs/mx23_olinuxino_defconfig             |  10 +-
>  configs/pinephone_defconfig                  |   7 +-
>  configs/socfpga_vining_fpga_defconfig        |  13 +-
>  doc/README.LED                               |  77 -----
>  doc/device-tree-bindings/options.yaml        |  79 +++++
>  doc/device-tree-bindings/options/u-boot.yaml | 136 ++++++++
>  drivers/led/Kconfig                          | 342 +------------------
>  drivers/misc/Kconfig                         |  13 -
>  drivers/misc/Makefile                        |   3 -
>  drivers/misc/gpio_led.c                      | 106 ------
>  drivers/misc/pca9551_led.c                   | 170 ---------
>  drivers/misc/status_led.c                    | 124 -------
>  drivers/timer/mpc83xx_timer.c                |   5 -
>  include/configs/eb_cpu5282.h                 |   6 -
>  include/status_led.h                         | 115 -------
>  net/bootp.c                                  |   7 -
>  net/net.c                                    |  33 --
>  35 files changed, 236 insertions(+), 1360 deletions(-)
>  delete mode 100644 board/st/stm32f429-discovery/led.c
>  delete mode 100644 cmd/legacy_led.c
>  delete mode 100644 doc/README.LED
>  create mode 100644 doc/device-tree-bindings/options.yaml
>  create mode 100644 doc/device-tree-bindings/options/u-boot.yaml
>  delete mode 100644 drivers/misc/gpio_led.c
>  delete mode 100644 drivers/misc/pca9551_led.c
>  delete mode 100644 drivers/misc/status_led.c
>  delete mode 100644 include/status_led.h
>
> --
> 2.43.0
>