[PATCH RFC v1] Dockerfile: Have "sandbox" build with i386 toolchain not x86_64 toolchain

[Tom Rini]

A long time ago, we had to use "i386" and "x86_64" toolchains for our
x86 platforms, depending on the target. We then moved to being able to
use the single "i386" toolchain to support all x86 platforms. At the
same time, we had been building sandbox with our "x86_64" toolchain in
CI. When x86 switched to being able to use a single toolchain we did not
update our CI buildman file to match. Do this now as we want to ensure
that sandbox is built with the same compiler version the rest of our
platforms are and not the host one.

Signed-off-by: Tom Rini <trini at konsulko.com>
---
Cc: Simon Glass <sjg at chromium.org>

I'm posting this as an RFC to start the discussion as when I mentioned
this to Simon on IRC, he was very much not in agreement.

My main argument is this, sandbox needs to use the same toolchain that
we compile (virtually) all other platforms with as one of the points is
to be able to catch warnings and compiler behavior changes as soon as
possible in our CI. And just like how developers can use
distribution-provided toolchains today, nothing changes in that regard,
we only make CI be more consistent now.
---
 tools/docker/Dockerfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
index 967ac89fbde8..e158bab6e570 100644
--- a/tools/docker/Dockerfile
+++ b/tools/docker/Dockerfile
@@ -280,7 +280,7 @@ RUN /bin/echo -e "[toolchain]\nroot = /usr" > ~/.buildman
 RUN /bin/echo -e "kernelorg = /opt/gcc-13.2.0-nolibc/*" >> ~/.buildman
 RUN /bin/echo -e "\n[toolchain-prefix]\nxtensa = /opt/2020.07/xtensa-dc233c-elf/bin/xtensa-dc233c-elf-" >> ~/.buildman;
 RUN /bin/echo -e "\n[toolchain-alias]\nsh = sh2" >> ~/.buildman
-RUN /bin/echo -e "\nsandbox = x86_64" >> ~/.buildman
+RUN /bin/echo -e "\nsandbox = i386" >> ~/.buildman
 RUN /bin/echo -e "\nx86 = i386" >> ~/.buildman;
 
 # Add mkbootimg tool
-- 
2.43.0