[PATCH 1/2] fs: Use ARCH_DMA_MINALIGN as default alignment for fs_read_alloc()

Simon Glass sjg at chromium.org
Thu Nov 7 14:44:32 CET 2024


Hi Nam,

On Wed, 6 Nov 2024 at 09:34, Nam Cao <namcao at linutronix.de> wrote:
>
> The comment above fs_read_alloc() explains:
>
>     @align: Alignment to use for memory allocation (0 for default)
>
> However, in the actual implementation, there is no alignment when @align is
> zero.
>
> This current default is probably fine for most cases. But for some block
> devices which transfer data via DMA, ARCH_DMA_MINALIGN is needed.
>
> Change the default alignment to ARCH_DMA_MINALIGN.
>
> Fixes: de7b5a8a1ac0 ("fs: Create functions to load and allocate a file")
> Signed-off-by: Nam Cao <namcao at linutronix.de>
> Tested-by: Javier Fernandez Pastrana <javier.pastrana at linutronix.de>
> ---
>  fs/fs.c | 4 ++++
>  1 file changed, 4 insertions(+)
>

Please update the function comment in fs.h to specify the default value

Regards,
Simon


More information about the U-Boot mailing list