[PATCH 0/5] collected fallout of porting an ATSAMA5D2 based board
Eugen Hristev
eugen.hristev at linaro.org
Tue Nov 12 14:45:05 CET 2024
On 10/18/24 11:30, Benedikt Spranger wrote:
> Hi,
>
> while porting an ATSAMA5D2 based board (booting from NAND flash with UBI)
> I stumbled over generic, NAND- and UBI related asperity:
>
> 1. tiny-printf does not handle NULL arguments to '%s' in a proper way
> 2. vtbl_check() has an useless debug output due to a typo
> 3. NAND: An informative output fails badly, if the NAND vendor is unknown
> 4. the nand_atmel driver lacks a vital initialisation
>
> OK, you might say the nand_atmel NAND driver is obsolete, but it was the
> only solution to get booting from NAND running. The new DM based NAND driver
> refused to do anything usefull, so I dropped it after spending a couple of
> days debugging it:
>
> <RANT>brilliant!</RANT>
>
> regards
> Benedikt Spranger
>
> Benedikt Spranger (5):
> tiny-printf: Handle NULL pointer argument to %s
> drivers/mtd/ubispl/ubispl.c: Fix error message
> mtd: nand: raw: Fix potential NULL pointer dereference
> mtd: nand: Update NAND manufacturer Ids
> mtd: nand: raw: atmel_nand: Add missing nand_scan_ident()
>
> drivers/mtd/nand/raw/atmel_nand.c | 4 ++++
> drivers/mtd/nand/raw/nand_base.c | 8 ++++----
> drivers/mtd/nand/raw/nand_ids.c | 22 ++++++++++++----------
> drivers/mtd/ubispl/ubispl.c | 2 +-
> include/linux/mtd/rawnand.h | 23 +++++++++++++----------
> lib/tiny-printf.c | 2 +-
> 6 files changed, 35 insertions(+), 26 deletions(-)
>
Coming back to these patches I had a look and except a typo , it looks good.
I can take these through at91 tree or maybe Michael you want to have a
look as they touch the MTD/NAND drivers ?
Thanks,
Eugen
More information about the U-Boot
mailing list