[PATCH 4/5] mtd: nand: Update NAND manufacturer Ids

[Eugen Hristev]

On 11/12/24 15:57, Benedikt Spranger wrote:
> On Tue, 12 Nov 2024 15:39:23 +0200
> Eugen Hristev <eugen.hristev at linaro.org> wrote:
> 
> Hi Eugen,
>> On 10/18/24 11:30, Benedikt Spranger wrote:
>>> Align manufacturer Ids with the Id list from Linux kernel v6.11.
>>> While at it, sort the entries in alphabetical order.
>>>
>>> Signed-off-by: Benedikt Spranger <b.spranger at linutronix.de>
>>> Reviewed-by: John Ogness <john.ogness at linutronix.de>
>>> ---
>>>  drivers/mtd/nand/raw/nand_ids.c | 22 ++++++++++++----------
>>>  include/linux/mtd/rawnand.h     | 23 +++++++++++++----------
>>>  2 files changed, 25 insertions(+), 20 deletions(-)
>>>
>>> diff --git a/drivers/mtd/nand/raw/nand_ids.c b/drivers/mtd/nand/raw/nand_ids.c
>>> index 4f46378ffe1..e40facf774c 100644
>>> --- a/drivers/mtd/nand/raw/nand_ids.c
>>> +++ b/drivers/mtd/nand/raw/nand_ids.c
>>> @@ -180,20 +180,22 @@ struct nand_flash_dev nand_flash_ids[] = {
>>>  
>>>  /* Manufacturer IDs */
>>>  struct nand_manufacturer nand_manuf_ids[] = {
>>> -	{NAND_MFR_TOSHIBA, "Toshiba", &toshiba_nand_manuf_ops},
>>> -	{NAND_MFR_SAMSUNG, "Samsung", &samsung_nand_manuf_ops},
>>> +	{NAND_MFR_AMD, "AMD/Spansion", &amd_nand_manuf_ops},
>>> +	{NAND_MFR_ATO, "ATO"},
>>> +	{NAND_MFR_EON, "Eon"},
>>> +	{NAND_MFR_EON, "ESMT"},
>>
>> Did you mean NAND_MFR_ESMT here ?
> Yes, fatfingered that...
> 
> Regards
>     Benedikt Spranger



Unfortunately you will need a new revision anyway.

I get this while building sama5d4ek_nandflash_defconfig


arm-none-linux-gnueabihf-ld.bfd: drivers/mtd/nand/raw/nand_base.o: in
function `nand_reset_data_interface':
..drivers/mtd/nand/raw/nand_base.c:948:(.text.nand_reset+0xc): undefined
reference to `nand_get_default_data_interface'
arm-none-linux-gnueabihf-ld.bfd: drivers/mtd/nand/raw/nand_base.o: in
function `nand_flash_detect_onfi':
..drivers/mtd/nand/raw/nand_base.c:3884:(.text.nand_detect+0x318):
undefined reference to `nand_manuf_ids'
arm-none-linux-gnueabihf-ld.bfd:
drivers/mtd/nand/raw/nand_base.c:3884:(.text.nand_detect+0x31c):
undefined reference to `nand_flash_ids'
arm-none-linux-gnueabihf-ld.bfd: drivers/mtd/nand/raw/nand_base.o: in
function `nand_init_data_interface':
drivers/mtd/nand/raw/nand_base.c:1047:(.text.nand_scan_ident+0x1ec):
undefined reference to `onfi_init_data_interface'
make[1]: *** [scripts/Makefile.xpl:542: spl/u-boot-spl] Error 1