[PATCH v1] imx: Fix critical thermal threshold

Peng Fan peng.fan at nxp.com
Wed Nov 13 06:27:23 CET 2024


Hi Francesco,

> Subject: [PATCH v1] imx: Fix critical thermal threshold
> 
> From: Francesco Dolcini <francesco.dolcini at toradex.com>
> 
> Fix the critical thermal threshold for i.MX processors, this was changed
> while moving the code from imx8m/imx9 directories into a shared
> place.
> 
> There is no need to keep the critical threshold 5 degrees less than the
> SoC maximum temperature threshold, what is actually going to happen
> in practice is that we are going to power-off the board when the SoC is
> still within its working temperature range.

Should we leave some margin for the critical temperature?

Thanks
Peng.

> 
> In addition to that this is a change in the actual behavior, that is
> introducing a regression to users, and it was hidden within a software
> refactoring.
> 
> Fixes: d0fe80890ab1 ("imx: Generalize fixup_thermal_trips")
> Signed-off-by: Francesco Dolcini <francesco.dolcini at toradex.com>
> ---
>  arch/arm/mach-imx/fdt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-imx/fdt.c b/arch/arm/mach-imx/fdt.c index
> ac782e3ee636..103c1fc5968a 100644
> --- a/arch/arm/mach-imx/fdt.c
> +++ b/arch/arm/mach-imx/fdt.c
> @@ -115,7 +115,7 @@ int fixup_thermal_trips(void *blob, const char
> *name)
> 
>  		temp = 0;
>  		if (!strcmp(type, "critical"))
> -			temp = 1000 * (maxc - 5);
> +			temp = 1000 * maxc;
>  		else if (!strcmp(type, "passive"))
>  			temp = 1000 * (maxc - 10);
>  		if (temp) {
> --
> 2.39.5



More information about the U-Boot mailing list