[PATCH] mmc: don't print 'MMC:' if there are no MMC devices

Tom Rini trini at konsulko.com
Wed Nov 13 15:24:37 CET 2024


On Wed, Nov 13, 2024 at 06:30:08AM +0100, Caleb Connolly wrote:

> It may be the case that MMC support is enabled even though the board
> we're booting on doesn't have any MMC devices. Move the print over to
> the print_mmc_devices() function where we can only print it if we
> actually have MMC devices.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>

I'm not sure I like this. What we do / don't find on startup is part of
the not-exactly-API. It's true that if we don't print an MMC line at
all, and we should have MMC, the user (and any scripts that parse
console output) but now we're also increasing the code size a little bit
too. I can be convinced this is a good idea, but I'm not there yet.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241113/e6c25514/attachment.sig>


More information about the U-Boot mailing list