[PATCH v4 3/9] docker: Support building for multiple architectures

Tom Rini trini at konsulko.com
Thu Nov 14 04:22:41 CET 2024


On Wed, Nov 13, 2024 at 11:53:34AM -0700, Simon Glass wrote:

> Add instructions on how to build the file for multiple architectures.
> Add a message indicating what is happening.
> 
> Update the documentation as well.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
[snip]
>  Or to use an existing container
>  
>  .. code-block:: bash
>  
> -    sudo docker pull trini/u-boot-gitlab-ci-runner:jammy-20240227-14Mar2024
> +    docker pull trini/u-boot-gitlab-ci-runner:jammy-20240227-14Mar2024

You inadvertently dropped sudo here.

> diff --git a/tools/docker/Dockerfile b/tools/docker/Dockerfile
> index 967ac89fbde..7f4b17ab0a4 100644
> --- a/tools/docker/Dockerfile
> +++ b/tools/docker/Dockerfile
> @@ -2,13 +2,25 @@
>  # This Dockerfile is used to build an image containing basic stuff to be used
>  # to build U-Boot and run our test suites.
>  
> +# Build with (for example):
> +# docker buildx build --platform linux/arm64/v8,linux/amd64 --tag sjg20/u-boot-gitlab-ci-runner-multiarch:jammy-20240808-03Nov2024 .
> +

The documentation is the example, please drop.

With those fixed:

Reviewed-by: Tom Rini <trini at konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241113/26f4e07e/attachment.sig>


More information about the U-Boot mailing list