[PATCH] iommu: qcom-smmu: allow SID 0

Neil Armstrong neil.armstrong at linaro.org
Thu Nov 14 12:05:19 CET 2024


On 13/11/2024 06:00, Caleb Connolly wrote:
> It turns out this is a very real stream ID. Who woulda thought?
> 
> Drop the 0 check on the SID, there's no reason for it to be there in the first
> place.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly at linaro.org>
> ---
>   drivers/iommu/qcom-hyp-smmu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iommu/qcom-hyp-smmu.c b/drivers/iommu/qcom-hyp-smmu.c
> index 1b5a09bb7b39..7e07487ad384 100644
> --- a/drivers/iommu/qcom-hyp-smmu.c
> +++ b/drivers/iommu/qcom-hyp-smmu.c
> @@ -133,9 +133,9 @@ static int get_stream_id(struct udevice *dev)
>   	struct ofnode_phandle_args args;
>   	int count = ofnode_parse_phandle_with_args(node, "iommus",
>   						   "#iommu-cells", 0, 0, &args);
>   
> -	if (count < 0 || args.args[0] == 0) {
> +	if (count < 0) {
>   		printf("Error: %s: iommus property not found or wrong number of cells\n",
>   		       __func__);
>   		return -EINVAL;
>   	}

Reviewed-by: Neil Armstrong <neil.armstrong at linaro.org>


More information about the U-Boot mailing list