[PATCH] test/cmd/wget.c: move net_test_wget() to the cmd test suite
Tom Rini
trini at konsulko.com
Fri Nov 15 01:14:00 CET 2024
On Tue, Nov 05, 2024 at 01:06:53PM +0100, Jerome Forissier wrote:
> Since net_test_wget() is testing a command and is in test/cmd it
> should be in the 'cmd' test suite, not 'lib'.
>
> Reported-by: Simon Glass <sjg at chromium.org>
> Signed-off-by: Jerome Forissier <jerome.forissier at linaro.org>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> ---
> test/cmd/wget.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
This leads to a sequencing error in tests:
------------------------------------ Captured stdout call -------------------------------------
=> ut dm dm_test_eth_act
Test: dm_test_eth_act: eth.c
Error: eth at 10002000 No valid MAC address found.
Error: eth at 10002000 No valid MAC address found.
Error: eth at 10002000 No valid MAC address found.
Error: eth at 10002000 No valid MAC address found.
Error: eth at 10002000 No valid MAC address found.
Error: eth at 10004000 No valid MAC address found.
Error: eth at 10002000 No valid MAC address found.
Error: eth at 10004000 No valid MAC address found.
Error: eth at 10002000 No valid MAC address found.
Error: eth at 10002000 No valid MAC address found.
test/dm/eth.c:284, dm_test_eth_act(): -ENODEV == net_loop(PING): Expected 0xffffffed (-19), got 0xffffffea (-22)
Test: dm_test_eth_act: eth.c (flat tree)
test/dm/eth.c:273, dm_test_eth_act(): addr = NULL: Expected non-null, got NULL
Test 'dm_test_eth_act' failed 2 times
Failures: 2
=>
Where it's fine when run by itself, but fails in CI/etc when running all
unit tests.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241114/ae374325/attachment.sig>
More information about the U-Boot
mailing list