[PATCH v3 4/6] net: lwip: Enable https:// support for wget

Ilias Apalodimas ilias.apalodimas at linaro.org
Fri Nov 15 15:24:47 CET 2024


[...]


> > > > +
> > > > > +       return 0;
> > > >
> > > > Yep, that's identical to what I had above without the allocation,
> > > > which indeed isn't needed.
> > > > Both of the versions are correct and I ask internally mbedTLS devs if
> > > > they have a preference.
> > > >
> > > > In any case feel free to send this, since Tom picked up the patches
> already
> > >
> > > OK. It will be interesting to see if coverity picks this up.
> >
> > Pick up what ? There's nothing wrong with the merged code. It does
> > gathers entropy in rounds of 8b
>
> If len is 40 (say) then this will memcpy() 40 bytes from the 8-byte
> variable.
>

Mbed TLS will only use 8 though, and the rest are garbage. In any case I
don't think coverity can catch that.

Cheers
/Ilias

>
> Regards,
> Simon
>


More information about the U-Boot mailing list