[PATCH v3 3/5] misc: k3_avs: Check validity of efuse voltage data

[Limaye, Aniket]

On 11/18/2024 10:42 AM, Manorit Chawdhry wrote:
> Hi Aniket,
> 
> On 12:45-20241116, Aniket Limaye wrote:
>> From: Reid Tonking <reidt at ti.com>
>>
>> k3_avs driver checks opp_ids when probing and overwrites the voltage
>> values in vd_data for the respective board. The new k3_check_opp() can
>> be called from board files to check the efuse data and returns 0 if
>> valid.
>>
>> Also add the same check in k3_avs_program_voltage() to error out if
>> the efuse data was not valid.
>>
>> Signed-off-by: Reid Tonking <reidt at ti.com>
>> Signed-off-by: Aniket Limaye <a-limaye at ti.com>
>> ---
> [..]
>>   
>> +/**
>> + * k3_check_opp: Check for presence of opp efuse
>> + * @opp_id: opp id to check if voltage is present
> 
> Could you document vdd_id as well which is another input to the function?
> 

Yep, missed to update the description when I updated the function.
Sent a v4

Regards,
Aniket

>> + *
>> + * Checks to see if an opp has voltage. k3_avs probe will populate
>> + * voltage data if efuse is present. Returns 0 if data is valid.
>> + */
>> +int k3_check_opp(struct udevice *dev, int vdd_id, int opp_id)
> 
> Regards,
> Manorit