[BUG regression in HEAD] efi: memory: use the lmb API's for allocating and freeing memory

[Sughosh Ganu]

On Wed, 20 Nov 2024 at 04:48, E Shattow <lucent at gmail.com> wrote:
>
> Hello,
>
> On HEAD some commits after v2024.10 I encounter a regression for
> `bootefi bootmgr` fail with error "Not a PE-COFF file";  The fall-thru
> case of global EFI boot is successful.
>
> Having run a git bisect I discover the first bad commit 22f2c9ed:
>
> $ git checkout -b master origin/master
> branch 'master' set up to track 'origin/master'.
> Switched to a new branch 'master'
> $ git bisect start
> status: waiting for both good and bad commits
> $ git bisect bad HEAD
> status: waiting for good commit(s), bad commit known
> $ git bisect good v2024.10
> Bisecting: 850 revisions left to test after this (roughly 10 steps)
> [82686e678e1587ddbd9570f82c58cdc3aecf2dbe] Merge branch 'staging' of
> https://source.denx.de/u-boot/custodians/u-boot-tegra
> $ git bisect good
> Bisecting: 422 revisions left to test after this (roughly 9 steps)
> [8963d433eb5d4a9f3a9def84e9c61a45c13e72bc] Merge tag
> 'u-boot-rockchip-20241026' of
> https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip
> $ git bisect bad
> Bisecting: 214 revisions left to test after this (roughly 8 steps)
> [0a504585d1cefeaf35ae8f860a5e5aa44dfffed5] arm: dts: k3-j722s-binman:
> Add support for HS-SE
> $ git bisect bad
> Bisecting: 106 revisions left to test after this (roughly 7 steps)
> [88057dab2cde8710ccc95d12fb312184e0b023ca] mtd: spi-nor: Allow flashes
> to specify MTD writesize
> $ git bisect good
> Bisecting: 53 revisions left to test after this (roughly 6 steps)
> [625d40ab120dbc6f45dbd975857f8f87e422bd0f] test: boot: fix
> bootflow_cmd_label for when DSA_SANDBOX is disabled
> $ git bisect bad
> Bisecting: 26 revisions left to test after this (roughly 5 steps)
> [5b9261fb0b1ed087387f2036d279fd3f4bb20a61] Makefile: Drop
> SPL_FIT_GENERATOR support
> $ git bisect good
> Bisecting: 13 revisions left to test after this (roughly 4 steps)
> [e1b6822d6522d94d579d53092342b542d368a04b] efi_memory: do not add RAM
> memory to the memory map
> $ git bisect bad
> Bisecting: 6 revisions left to test after this (roughly 3 steps)
> [2f6191526a1325b6ddb59795a093eca69dbf8976] lmb: notify of any changes
> to the LMB memory map
> $ git bisect bad
> Bisecting: 2 revisions left to test after this (roughly 2 steps)
> [3c6896ad2fb876b0a23202f62a83c0d44380c9ea] lmb: add a flag to allow
> suppressing memory map change notification
> $ git bisect good
> Bisecting: 0 revisions left to test after this (roughly 1 step)
> [22f2c9ed9f533a56bed09bd4e0e37852b6b9f3b1] efi: memory: use the lmb
> API's for allocating and freeing memory
> $ git bisect bad
> Bisecting: 0 revisions left to test after this (roughly 0 steps)
> [eb052cbb896fee6f947765b44b0d80a54b19ce1a] lmb: add and reserve memory
> above ram_top
> $ git bisect good
> 22f2c9ed9f533a56bed09bd4e0e37852b6b9f3b1 is the first bad commit
>
> A commit is good if Star64 boots and absent the error about "Not a
> PE-COFF file" (duly confirmed by eficonfig to adjust boot order
> allowing removable media of an OS installer image on SD Card to be the
> priority, verifying that the installer runs as expected).  A commit is
> bad if U-Boot crashes and/or has the error "Not a PE-COFF file".

Can you post the output of the following. Thanks.

1) running the 'bdinfo' command

2) do you get any errors when running the 'bootefi bootmgr' command
other than what you mention above

3) What exactly do you mean by "global EFI boot is successful"

-sughosh

>
> For context, the Star64 eMMC contains here an installed Debian Linux
> OS in the usual way with Grub2 EFI on the EFI System Partition there,
> and that image boots fine from U-Boot v2024.10 also when loaded into
> memory and using 'bootefi' directly on that memory address.
>
> Best regards,
>
> -E Shattow