[PATCH v1 1/3] doc: develop: Fix typos and wording in binman/binman.rst

Lothar Rubusch l.rubusch at gmail.com
Wed Nov 20 11:55:35 CET 2024


Hi, thank you all! This is outstanding, such a fast feedback! As I
also just ran a tool over the texts, adjusted formatting and
reverted/accepted some changes manually to my knowledge (I'm not a
native speaker). Please, could you clarify the following?

On Wed, Nov 20, 2024 at 12:10 AM Heinrich Schuchardt <xypron.glpk at gmx.de> wrote:
>
> Am 19. November 2024 23:28:35 MEZ schrieb Lothar Rubusch <l.rubusch at gmail.com>:
> >Fix some typos and duplicate words in binman.rst.
> >
> >Signed-off-by: Lothar Rubusch <l.rubusch at gmail.com>
> >---
> > tools/binman/binman.rst | 238 ++++++++++++++++++++--------------------
> > 1 file changed, 119 insertions(+), 119 deletions(-)
> >
> >diff --git a/tools/binman/binman.rst b/tools/binman/binman.rst
> >index 381e55686f..620b5fa048 100644
> >--- a/tools/binman/binman.rst
> >+++ b/tools/binman/binman.rst
> >@@ -5,7 +5,7 @@ Introduction
> > ============
> >
> > Firmware often consists of several components which must be packaged together.
> >-For example, we may have SPL, U-Boot, a device tree and an environment area
> >+For example, we may have SPL, U-Boot, a device-tree and an environment area
>
> Both devicetree and device tree are common spelling variants. See for instance https://www.devicetree.org/.
>
> > grouped together and placed in MMC flash. When the system starts, it must be
> > able to find these pieces.
> >
> >@@ -19,7 +19,7 @@ together.
> > What it does
> > ------------
> >
> >-Binman reads your board's device tree and finds a node which describes the
> >+Binman reads your board's device-tree and finds a node which describes the
> > required image layout. It uses this to work out what to place where.
> >
> > Binman provides a mechanism for building images, from simple SPL + U-Boot
> >@@ -31,13 +31,13 @@ needed.
> > Features
> > --------
> >
> >-Apart from basic padding, alignment and positioning features, Binman supports
> >+Apart from basic padding, alignment, and positioning features, Binman supports
> > hierarchical images, compression, hashing and dealing with the binary blobs
> >-which are a sad trend in open-source firmware at present.
> >+which is a sad trend in open-source firmware at present.
>
> It is not Binmans support (singular) that is a sad trend. It is binary blobs (plural) that are a sad trend.
>

Sure. But isn't it possible also to read it like this (below)? May I
split it as follows:
"...hierarchical images, compression, hashing and dealing with the
binary blobs. Dealing with binary blobs is a sad trend in open-source
firmware at present."

I mean I catch the point here, as anyone else probably does. This not
a problem, just let me know. Or, if not, I revert to the original.


More information about the U-Boot mailing list