[PATCH v3 14/20] siemens: capricorn: small board updates

[Sverdlin, Alexander]

Hi Heiko!

On Thu, 2024-11-21 at 06:25 +0100, Heiko Schocher wrote:
> with newest SCFW build_info() works now, so call it
> from checkboard() now.
> 
> As we only use uart2 as console, do not init uart0.
> 
> Signed-off-by: Heiko Schocher <hs at denx.de>

Reviewed-by: Alexander Sverdlin <alexander.sverdlin at siemens.com>

> ---
> 
> (no changes since v2)
> 
> Changes in v2:
> - add comments from Fabio
>   rename subject line and rework commit message,
>   alse remove unneeded comment in checkboard()
> 
>  board/siemens/capricorn/board.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/board/siemens/capricorn/board.c b/board/siemens/capricorn/board.c
> index ad474d9baa0..bf04f12c75b 100644
> --- a/board/siemens/capricorn/board.c
> +++ b/board/siemens/capricorn/board.c
> @@ -63,8 +63,7 @@ int board_early_init_f(void)
>  	sc_pm_clock_rate_t rate = SC_80MHZ;
>  	int ret;
>  
> -	ret = sc_pm_setup_uart(SC_R_UART_0, rate);
> -	ret |= sc_pm_setup_uart(SC_R_UART_2, rate);
> +	ret = sc_pm_setup_uart(SC_R_UART_2, rate);
>  	if (ret)
>  		return ret;
>  
> @@ -271,11 +270,7 @@ int checkboard(void)
>  {
>  	puts("Board: Capricorn\n");
>  
> -	/*
> -	 * Running build_info() doesn't work with current SCFW blob.
> -	 * Uncomment below call when new blob is available.
> -	 */
> -	/*build_info();*/
> +	build_info();
>  
>  	print_bootinfo();
>  	return 0;

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com