[PATCH v5 05/11] riscv: dts: jh7110: Add u-boot device tree for JH7110 based boards

[Hal Feng]

On 11/22/2024 8:28 AM, E Shattow wrote:
> On Mon, Nov 18, 2024 at 6:06 PM Hal Feng <hal.feng at starfivetech.com> wrote:
>>
>> To support the other JH7110 based boards, add u-boot
>> device tree for them.
>>
>> Cc: Heinrich Schuchardt <xypron.glpk at gmx.de>
>> Cc: H Bell <dmoo_dv at protonmail.com>
>> Signed-off-by: Hal Feng <hal.feng at starfivetech.com>
>> ---
>>  arch/riscv/dts/jh7110-milkv-mars-u-boot.dtsi           | 10 ++++++++++
>>  arch/riscv/dts/jh7110-pine64-star64-u-boot.dtsi        |  6 ++++++
>>  .../dts/jh7110-starfive-visionfive-2-v1.2a-u-boot.dtsi |  6 ++++++
>>  3 files changed, 22 insertions(+)
>>  create mode 100644 arch/riscv/dts/jh7110-milkv-mars-u-boot.dtsi
>>  create mode 100644 arch/riscv/dts/jh7110-pine64-star64-u-boot.dtsi
>>  create mode 100644 arch/riscv/dts/jh7110-starfive-visionfive-2-v1.2a-u-boot.dtsi
>>
>> diff --git a/arch/riscv/dts/jh7110-milkv-mars-u-boot.dtsi b/arch/riscv/dts/jh7110-milkv-mars-u-boot.dtsi
>> new file mode 100644
>> index 0000000000..cf4f0d4c06
>> --- /dev/null
>> +++ b/arch/riscv/dts/jh7110-milkv-mars-u-boot.dtsi
>> @@ -0,0 +1,10 @@
>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>> +/*
>> + * Copyright (C) 2024 StarFive Technology Co., Ltd.
>> + */
>> +
>> +#include "jh7110-common-u-boot.dtsi"
>> +
>> +&phy0 {
>> +       /delete-property/ motorcomm,tx-clk-10-inverted;
>> +};
> 
> Why delete this property?

Here I kept the same with the configuration before OF_UPSTREAM applied.
Is this property required in U-Boot?

> 
>> diff --git a/arch/riscv/dts/jh7110-pine64-star64-u-boot.dtsi b/arch/riscv/dts/jh7110-pine64-star64-u-boot.dtsi
>> new file mode 100644
>> index 0000000000..9df1e5db55
>> --- /dev/null
>> +++ b/arch/riscv/dts/jh7110-pine64-star64-u-boot.dtsi
>> @@ -0,0 +1,6 @@
>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>> +/*
>> + * Copyright (C) 2024 StarFive Technology Co., Ltd.
>> + */
>> +
>> +#include "jh7110-common-u-boot.dtsi"
>> diff --git a/arch/riscv/dts/jh7110-starfive-visionfive-2-v1.2a-u-boot.dtsi b/arch/riscv/dts/jh7110-starfive-visionfive-2-v1.2a-u-boot.dtsi
>> new file mode 100644
>> index 0000000000..9df1e5db55
>> --- /dev/null
>> +++ b/arch/riscv/dts/jh7110-starfive-visionfive-2-v1.2a-u-boot.dtsi
>> @@ -0,0 +1,6 @@
>> +// SPDX-License-Identifier: GPL-2.0 OR MIT
>> +/*
>> + * Copyright (C) 2024 StarFive Technology Co., Ltd.
>> + */
>> +
>> +#include "jh7110-common-u-boot.dtsi"
>> --
>> 2.43.2
>>
> 
> Reviewed-by: E Shattow <lucent at gmail.com>

Thanks for your review.

Best regards,
Hal