[PATCH v5 02/11] riscv: dts: jh7110: Make u-boot device trees adapting to upstream DT

[E Shattow]

On Thu, Nov 21, 2024 at 11:44 PM Sumit Garg <sumit.garg at linaro.org> wrote:
>
> On Fri, 22 Nov 2024 at 12:12, E Shattow <lucent at gmail.com> wrote:
> >
> > On Mon, Nov 18, 2024 at 8:06 PM Sumit Garg <sumit.garg at linaro.org> wrote:
> > >
> > > Hi,
> > >
> > > On Tue, 19 Nov 2024 at 07:35, Hal Feng <hal.feng at starfivetech.com> wrote:
> > > >
> > > > Add u-boot features to the U-Boot device tree.
> > > >
> > >
> > > For follow-up work, I would suggest minimizing U-Boot specific DT
> > > bits. You can either re-use what's available in upstream DT or push
> > > U-Boot specific changes (eg. bootph-* properties etc.) upstream.
> > >
> > > FWIW:
> > >
> > > Acked-by: Sumit Garg <sumit.garg at linaro.org>
> > >
> > > -Sumit
> >
> > Sumit, with the whole series applied this U-Boot specific DT addition
> > is confined (with exception of what I comment on below for rx delay
> > values on VF2 1.3b) to a single include file. Looking at linux-next
> > there is a bit of re-organization since the Framework / DeepComputing
> > JH7110 mainboard moved more nodes out of the common file and into
> > board specific dts. When upstream dts settles again then there will be
> > some more work to update this anyways. Is it any blocker for you now?
> >
>
> No, it's not really a blocker for me. Actually it will make life
> further easier for the board maintainers in future if they upstream
> everything in *-u-boot.dtsi to Linux DT. This will ensure that no more
> rework is needed when DT is synced from Linux and rather U-Boot uses
> the same DT as Linux does.
>
> -Sumit

Does the "snps,dw-mshc" override of compatible belong here or should
the driver in U-Boot be amended to accept "starfive,jh7110-mmc" as in
upstream dts?

-E