[PATCH v2 1/5] board: ti: am64x: evm: Set "dfu_alt_info" only if interface is Serial Flash

[Vignesh Raghavendra]

On 24/11/24 12:37, Siddharth Vadapalli wrote:
> Commit 5b84d2de5e6c ("board: am64x: Define capsule update firmware info")
> updated the "dfu_alt_info" variable to support use-cases with Serial Flash.
> However, this breaks use-cases where interface is not Serial Flash ("sf").
> Fix this by setting "dfu_alt_info" only when the interface is "sf".
> 
> Fixes: 5b84d2de5e6c ("board: am64x: Define capsule update firmware info")
> Signed-off-by: Siddharth Vadapalli <s-vadapalli at ti.com>
> ---
> 
> v1:
> https://patchwork.ozlabs.org/project/uboot/patch/20241124051545.382397-2-s-vadapalli@ti.com/
> Changes since v1:
> - Replaced "SPI Flash" with "Serial Flash" everywhere.
> 
> Regards,
> Siddharth.
> 
>  board/ti/am64x/evm.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/board/ti/am64x/evm.c b/board/ti/am64x/evm.c
> index 00b8317d6b..18f7770bc1 100644
> --- a/board/ti/am64x/evm.c
> +++ b/board/ti/am64x/evm.c
> @@ -56,7 +56,13 @@ struct efi_capsule_update_info update_info = {
>  #if IS_ENABLED(CONFIG_SET_DFU_ALT_INFO)
>  void set_dfu_alt_info(char *interface, char *devstr)
>  {
> -	if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT))
> +	/*
> +	 * Since the EFI Capsule support is enabled only for Serial Flash,
> +	 * update the "dfu_alt_info" environment variable only if the
> +	 * interface happens to be "sf" (Serial Flash).
> +	 */
> +	if (IS_ENABLED(CONFIG_EFI_HAVE_CAPSULE_SUPPORT) &&
> +	    (strcmp(interface, "sf") == 0))

IIUC, EFI_HAVE_CAPSULE_SUPPORT is probably only functional at U-Boot
proper and not at SPL (I dont see any SPL_EFI_* options), so would this
work instead?

	if (CONFIG_IS_ENABLED(EFI_HAVE_CAPSULE_SUPPORT) {
		...
	}

>  		env_set("dfu_alt_info", update_info.dfu_string);
>  }
>  #endif

-- 
Regards
Vignesh
https://ti.com/opensource