[PATCH 10/20] arm: rockchip: add RK3576-specific syscon ids

[Quentin Schulz]

Hi Heiko,

On 11/21/24 3:27 PM, Heiko Stuebner wrote:
> From: Detlev Casanova <detlev.casanova at collabora.com>
> 
> The rk3576 defines some more different syscons, namely the IOC-syscon
> holding io-controller registers and sdgmac holding settings for the
> gmac controller.
> 
> Signed-off-by: Detlev Casanova <detlev.casanova at collabora.com>
> Signed-off-by: Heiko Stuebner <heiko at sntech.de>
> ---
>   arch/arm/include/asm/arch-rockchip/clock.h | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/include/asm/arch-rockchip/clock.h b/arch/arm/include/asm/arch-rockchip/clock.h
> index 73e5283108b..82305ef17ae 100644
> --- a/arch/arm/include/asm/arch-rockchip/clock.h
> +++ b/arch/arm/include/asm/arch-rockchip/clock.h
> @@ -32,6 +32,8 @@ enum {
>   	ROCKCHIP_SYSCON_PIPE_PHY2_GRF,
>   	ROCKCHIP_SYSCON_VOP_GRF,
>   	ROCKCHIP_SYSCON_VO_GRF,
> +	ROCKCHIP_SYSCON_IOC,
> +	ROCKCHIP_SYSCON_SDGMAC,

We should really start migrating away from this.

I would hope that the generic syscon would be enough for us. The issue 
would be to migrate all

syscon_get_first_range(ROCKCHIP_SYSCON_*);

we use in the code by checking the DT instead, e.g. rockchip,grf 
property for ROCKCHIP_SYSCON_GRF. For DT-less driver (e.g. SDRAM), I 
guess just using a hardcoded address would do just fine? Like, I don't 
understand what this brings us.

Anyway, a topic for another patch series :)

Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>

Thanks!
Quentin