[PATCH 1/2] efi_stub: Sync the debug UART definition like other platform
Kever Yang
kever.yang at rock-chips.com
Fri Nov 29 04:22:50 CET 2024
Hi Tom, Simon,
With these two patches, I didn't see error report in efi_stub for
disable DEBUG_UART,
but I still get CI build error below, but I can't identify what's the
problem, could you help to take a look:
https://source.denx.de/u-boot/custodians/u-boot-rockchip/-/jobs/963215
Thanks,
- Kever
On 2024/11/28 11:47, Kever Yang wrote:
> The debug UART interface is available when CONFIG_DEBUG_UART is defined,
> sync with the other platforms to use the same definition.
>
> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> ---
>
> lib/efi/efi_stub.c | 16 ++++++++++------
> 1 file changed, 10 insertions(+), 6 deletions(-)
>
> diff --git a/lib/efi/efi_stub.c b/lib/efi/efi_stub.c
> index 40fc29d9adf..5179c5b2c09 100644
> --- a/lib/efi/efi_stub.c
> +++ b/lib/efi/efi_stub.c
> @@ -9,7 +9,6 @@
> * EFI application. It can be built either in 32-bit or 64-bit mode.
> */
>
> -#include <debug_uart.h>
> #include <efi.h>
> #include <efi_api.h>
> #include <errno.h>
> @@ -55,10 +54,6 @@ struct __packed desctab_info {
> * considering if we start needing more U-Boot functionality. Note that we
> * could then move get_codeseg32() to arch/x86/cpu/cpu.c.
> */
> -void _debug_uart_init(void)
> -{
> -}
> -
> void putc(const char ch)
> {
> struct efi_priv *priv = efi_get_priv();
> @@ -83,12 +78,21 @@ void puts(const char *str)
> putc(*str++);
> }
>
> -static void _debug_uart_putc(int ch)
> +#ifdef CONFIG_DEBUG_UART
> +
> +#include <debug_uart.h>
> +
> +void _debug_uart_init(void)
> +{
> +}
> +
> +static inline void _debug_uart_putc(int ch)
> {
> putc(ch);
> }
>
> DEBUG_UART_FUNCS
> +#endif
>
> void *memcpy(void *dest, const void *src, size_t size)
> {
More information about the U-Boot
mailing list