[PATCH 1/4] ARM: dts: imx: Make DRAM coding GPIOs available in all phases on Data Modul i.MX8M Mini/Plus eDM SBC

Marek Vasut marex at denx.de
Fri Nov 29 04:13:20 CET 2024


On 11/28/24 12:48 PM, Quentin Schulz wrote:
> Hi Marek,
> 
> On 11/28/24 4:25 AM, Marek Vasut wrote:
>> The DRAM configuration GPIO straps must be accessible in all boot phases
>> because the GPIOs are sampled both in U-Boot SPL as well as early on in
>> U-Boot proper. The already present bootph-pre-ram DT property made the
>> GPIO controllers available in SPL, but not early on in U-Boot proper,
>> which made gpio_request_list_by_name_nodev() in board dmo_get_memcfg()
>> fail. Add missing bootph-all DT property to all GPIO controllers which
>> are referenced in dmo,ram-coding-gpios DT property to make those GPIO
>> controllers available early in U-Boot proper as well.
>>
>> Fixes: 8c103c33fb14 ("dm: dts: Convert driver model tags to use new 
>> schema")
>> Signed-off-by: Marek Vasut <marex at denx.de>
>> ---
>> Cc: "NXP i.MX U-Boot Team" <uboot-imx at nxp.com>
>> Cc: Fabio Estevam <festevam at gmail.com>
>> Cc: Quentin Schulz <quentin.schulz at cherry.de>
>> Cc: Sean Anderson <seanga2 at gmail.com>
>> Cc: Simon Glass <sjg at chromium.org>
>> Cc: Stefano Babic <sbabic at denx.de>
>> Cc: Tom Rini <trini at konsulko.com>
>> Cc: u-boot at lists.denx.de
>> ---
>> NOTE: For v2025.01
>> ---
>>   arch/arm/dts/imx8mm-data-modul-edm-sbc-u-boot.dtsi | 1 +
>>   arch/arm/dts/imx8mp-data-modul-edm-sbc-u-boot.dtsi | 2 ++
>>   2 files changed, 3 insertions(+)
>>
>> diff --git a/arch/arm/dts/imx8mm-data-modul-edm-sbc-u-boot.dtsi b/ 
>> arch/arm/dts/imx8mm-data-modul-edm-sbc-u-boot.dtsi
>> index a235e088fa4..babe51ebdc1 100644
>> --- a/arch/arm/dts/imx8mm-data-modul-edm-sbc-u-boot.dtsi
>> +++ b/arch/arm/dts/imx8mm-data-modul-edm-sbc-u-boot.dtsi
>> @@ -77,6 +77,7 @@
>>   &gpio2 {
>>       bootph-pre-ram;
>> +    bootph-all;
> 
> aren't those supposed to be bootph-some-ram for matching U-Boot proper 
> pre-reloc? bootph-all would enable it in TPL as well (if there's one on 
> imx8mp).
> 
> https://docs.u-boot.org/en/latest/develop/driver-model/design.html#pre- 
> relocation-support
> 
> If not, isn't bootph-pre-ram implied when bootph-all is selected?
Fixed in v2 via bootph-some-ram , thanks .


More information about the U-Boot mailing list