[PATCH 1/1] test: don't call restart_uboot in EFI watchdog test

[Ilias Apalodimas]

On Wed, 2 Oct 2024 at 01:53, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> Calling u_boot_console.restart_uboot() in
> test_efi_selftest_watchdog_reboot() may lead to incorrect results.
>
> While the watchdog triggered reboot is running thee test environment may

s/thee/the

> need some time before triggering a reboot itself. This may lead to
> duplicate output of the U-Boot greeter which is recorded as an error.
>
> Reported-by: Tom Rini <trini at konsulko.com>
> Fixes: df172e117d1d ("test/py: test reboot by EFI watchdog")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  test/py/tests/test_efi_selftest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/py/tests/test_efi_selftest.py b/test/py/tests/test_efi_selftest.py
> index 43f24245582..310d8ed294a 100644
> --- a/test/py/tests/test_efi_selftest.py
> +++ b/test/py/tests/test_efi_selftest.py
> @@ -58,7 +58,7 @@ def test_efi_selftest_watchdog_reboot(u_boot_console):
>      u_boot_console.run_command(cmd='bootefi selftest', wait_for_prompt=False)
>      if u_boot_console.p.expect(['resetting', 'U-Boot']):
>          raise Exception('Reset failed in \'watchdog reboot\' test')
> -    u_boot_console.restart_uboot()
> +    u_boot_console.run_command(cmd='', send_nl=False, wait_for_reboot=True)
>
>  @pytest.mark.buildconfigspec('cmd_bootefi_selftest')
>  def test_efi_selftest_text_input(u_boot_console):
> --
> 2.45.2
>

Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>