[PATCH v5 01/11] led: toggle LED on initial SW blink

Christian Marangi ansuelsmth at gmail.com
Thu Oct 3 00:59:13 CEST 2024


On Wed, Oct 02, 2024 at 04:55:41PM -0600, Simon Glass wrote:
> On Tue, 1 Oct 2024 at 06:25, Christian Marangi <ansuelsmth at gmail.com> wrote:
> >
> > We currently init the LED OFF when SW blink is triggered when
> > on_state_change() is called. This can be problematic for very short
> > period as the ON/OFF blink might never trigger.
> >
> > Toggle the LED (ON if OFF, OFF if ON) on initial SW blink to handle this
> > corner case and better display a LED blink from the user.
> >
> > Signed-off-by: Christian Marangi <ansuelsmth at gmail.com>
> > ---
> >  drivers/led/led_sw_blink.c | 17 +++++++++++++++--
> >  1 file changed, 15 insertions(+), 2 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> Running a little bit blind here without a changelog. If you use patman
> it will do this automatically.

The cover letter didn't slip in the mailing list? Changelog is there or
I'm missing something?

-- 
	Ansuel


More information about the U-Boot mailing list