[PATCH v4 2/7] drivers: misc: k3_avs: Check return code while programming AVS

Manorit Chawdhry m-chawdhry at ti.com
Fri Oct 4 08:24:30 CEST 2024


Check if AVS could not be programmed and print a warning.

Fixes: 9d233b4e3ed6 ("misc: k3_avs: add driver for K3 Adaptive Voltage Scaling Class 0")
Reviewed-by: Udit Kumar <u-kumar1 at ti.com>
Signed-off-by: Manorit Chawdhry <m-chawdhry at ti.com>
---

Notes:
    v4:
    Pick the following change from v2, had gotten missed.
    https://lore.kernel.org/all/fa14fd9c-2b6f-4a09-ab2f-01d90106cd2b@ti.com/

 drivers/misc/k3_avs.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/k3_avs.c b/drivers/misc/k3_avs.c
index 87471cc3b16a..66ad747f2dd8 100644
--- a/drivers/misc/k3_avs.c
+++ b/drivers/misc/k3_avs.c
@@ -391,7 +391,10 @@ static int k3_avs_probe(struct udevice *dev)
 		if (vd->flags & VD_FLAG_INIT_DONE)
 			continue;
 
-		k3_avs_program_voltage(priv, vd, vd->opp);
+		ret = k3_avs_program_voltage(priv, vd, vd->opp);
+		if (ret)
+			dev_warn(dev, "Could not program AVS voltage for VD%d, vd->opp=%d, ret=%d\n",
+				 vd->id, vd->opp, ret);
 	}
 
 	if (!device_is_compatible(priv->dev, "ti,am654-avs"))

-- 
2.46.0



More information about the U-Boot mailing list