[PATCH v2 18/18] rockchip: Provided SPL control over efuse presence

Jonas Karlman jonas at kwiboo.se
Fri Oct 4 08:28:40 CEST 2024


Hi Tom,

On 2024-10-04 00:25, Tom Rini wrote:
> On Fri, Sep 20, 2024 at 05:08:52PM +0200, Jonas Karlman wrote:
>> Hi Simon,
>>
>> On 2024-09-20 09:24, Simon Glass wrote:
>>> This driver should not generally be present in SPL, even if misc devices
>>> are enabled. Update the Makefile rule accordingly.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>> ---
>>>
>>> (no changes since v1)
>>>
>>>  drivers/misc/Makefile | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile
>>> index e53d52c47b3..ff984d7b191 100644
>>> --- a/drivers/misc/Makefile
>>> +++ b/drivers/misc/Makefile
>>> @@ -68,7 +68,7 @@ obj-$(CONFIG_QFW_MMIO) += qfw_mmio.o
>>>  obj-$(CONFIG_QFW_SMBIOS) += qfw_smbios.o
>>>  obj-$(CONFIG_SANDBOX) += qfw_sandbox.o
>>>  endif
>>> -obj-$(CONFIG_ROCKCHIP_EFUSE) += rockchip-efuse.o
>>> +obj-$(CONFIG_$(SPL_TPL_)ROCKCHIP_EFUSE) += rockchip-efuse.o
>>>  obj-$(CONFIG_ROCKCHIP_OTP) += rockchip-otp.o
>>
>> Please also include similar change for ROCKCHIP_OTP, the EFUSE and OTP
>> drivers provide same functionality, just for different Rockchip SoCs.
> 
> This is reasonable as a clean-up I believe (and possibly post "xPL"
> series being merged), to reduce churn.
> 

I was to quick before reading this and have already sent a fix to keep
these two drivers in sync.

https://lore.kernel.org/r/20241004062136.491995-1-jonas@kwiboo.se/

Regards,
Jonas


More information about the U-Boot mailing list