[PATCH v1 3/4] x86: cpu: Add a few prototypes to the header file

[Simon Glass]

On Sat, 5 Oct 2024 at 13:14, Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
>
> The compiler is not happy to have no prototypes for the functions that
> are not defined static. Add them. This helps avoiding the compiler warnings:
>
>   arch/x86/cpu/cpu.c:197:13: warning: no previous prototype for ‘board_final_init’ [-Wmissing-prototypes]
>   arch/x86/cpu/cpu.c:205:13: warning: no previous prototype for ‘board_final_cleanup’ [-Wmissing-prototypes]
>   arch/x86/cpu/cpu.c:307:5: warning: no previous prototype for ‘reserve_arch’ [-Wmissing-prototypes]
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
>  arch/x86/include/asm/cpu.h | 7 +++++++
>  1 file changed, 7 insertions(+)
>

Reviewed-by: Simon Glass <sjg at chromium.org>

OK, but could you add proper comments for these?


> diff --git a/arch/x86/include/asm/cpu.h b/arch/x86/include/asm/cpu.h
> index 073f80b07f10..d71bc1b80c05 100644
> --- a/arch/x86/include/asm/cpu.h
> +++ b/arch/x86/include/asm/cpu.h
> @@ -298,4 +298,11 @@ u32 cpu_get_stepping(void);
>   */
>  int cpu_phys_address_size(void);
>
> +void board_final_init(void);
> +void board_final_cleanup(void);
> +
> +#ifndef CONFIG_EFI_STUB
> +int reserve_arch(void);
> +#endif
> +
>  #endif
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>