[PATCH v2 1/2] pci: Add TI K3 Cadence PCIe Controller

[Siddharth Vadapalli]

On Fri, Oct 11, 2024 at 07:15:03PM -0600, Tom Rini wrote:

Hello Tom,

> On Fri, Oct 11, 2024 at 06:32:57PM +0530, Siddharth Vadapalli wrote:
> > Add support for the Cadence PCIe Controller present on TI's K3 SoCs.
> > This driver is an adaptation of the Linux driver.
> > 
> > Signed-off-by: Siddharth Vadapalli <s-vadapalli at ti.com>
> > ---
> >  drivers/pci/Kconfig        |   6 +
> >  drivers/pci/Makefile       |   1 +
> >  drivers/pci/pcie_cdns_ti.c | 851 +++++++++++++++++++++++++++++++++++++
> >  3 files changed, 858 insertions(+)
> >  create mode 100644 drivers/pci/pcie_cdns_ti.c
> 
> Please update MAINTAINERS somewhere for this.
> 
> > +#define CDNS_PCIE_LM_BAR_CFG_CTRL_DISABLED		0x0
> > +#define  CDNS_PCIE_LM_BAR_CFG_CTRL_MEM_32BITS		0x4
> > +#define  CDNS_PCIE_LM_BAR_CFG_CTRL_PREFETCH_MEM_32BITS	0x5
> > +#define  CDNS_PCIE_LM_BAR_CFG_CTRL_MEM_64BITS		0x6
> > +#define  CDNS_PCIE_LM_BAR_CFG_CTRL_PREFETCH_MEM_64BITS	0x7
> 
> Here and maybe elsewhere, why the inconsistent indentation?

Thank you for reviewing the patch. I will add the MAINTAINERS entry and
make the indentation consistent in the v3 series.

Regards,
Siddharth.