[PATCH 1/1] net: phy: Do not do CL22 phy reset before ethernet phy driver probe
Marek Vasut
marek.vasut at mailbox.org
Mon Oct 14 10:43:50 CEST 2024
On 10/14/24 9:06 AM, Sky Huang wrote:
> From: "SkyLake.Huang" <skylake.huang at mediatek.com>
>
> Remove unnecessary CL22 phy reset before ethernet phy driver
> probe. Lots of ethernet phys requires driver to load firmware.
> Before that, CL22 phy reset may lead to malfunction.
>
> Signed-off-by: SkyLake.Huang <skylake.huang at mediatek.com>
> ---
> drivers/net/phy/phy.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
> index 716a1d46111..e6fed8c41d7 100644
> --- a/drivers/net/phy/phy.c
> +++ b/drivers/net/phy/phy.c
> @@ -839,8 +839,6 @@ struct phy_device *phy_find_by_mask(struct mii_dev *bus, uint phy_mask)
> static void phy_connect_dev(struct phy_device *phydev, struct udevice *dev,
> phy_interface_t interface)
> {
> - /* Soft Reset the PHY */
> - phy_reset(phydev);
> if (phydev->dev && phydev->dev != dev) {
> printf("%s:%d is connected to %s. Reconnecting to %s\n",
> phydev->bus->name, phydev->addr,
This needs clarification and likely has to be handled differently.
Removing the reset would leave the PHY in potentially undefined state.
Which PHY is affected by this ?
More information about the U-Boot
mailing list