[PATCH v4 0/5] android_ab: introduce bcb ab_dump command and provide several bcb fixes
Dmitry Rokosov
ddrokosov at salutedevices.com
Mon Oct 14 23:06:12 CEST 2024
The patch series include changes:
- move ab_select_slot() documentation to @ notation
- move ab_select command to bcb subcommands
- introduce the ab_dump command to print the content of the BCB
block; it's useful for debugging A/B logic on supported boards
- fix the slot suffix format in the ABC block to align with official
Android BCB specifications
- add a test for the ab_dump command to verify the accuracy of each
field within the ABC data displayed, it's also useful for testing
slot_suffix problem code paths
Changes v3 since v2 at [2]:
- return "Legend" block for bcb command
- additionally, verify the CONFIG_ANDROID_AB configuration alongside
CONFIG_CMD_BCB to ensure that the A/B scheme is used for the
designated board.
Changes v2 since v1 at [1]:
- move ab_select_slot() documentation to @ notation
- move ab_select command to bcb subcommands per Simon and Mattijs
suggestions
- redesign ab_dump as bcb subcommand
- use spaces instead of tabs in the ab_dump command output
- print hex values in the lowercase
- add RvB tags
Links:
[1] https://lore.kernel.org/all/20240725194716.32232-1-ddrokosov@salutedevices.com/
[2] https://lore.kernel.org/all/20240911214945.15873-1-ddrokosov@salutedevices.com/
Signed-off-by: Dmitry Rokosov <ddrokosov at salutedevices.com>
---
Changes in v4:
- add #ifdefs for CONFIG_ANDROID_AB in cmd/bcb.c to allow the usage of
the bcb command without A/B enabled
- run the savedefconfig command for all defconfigs that include the
CMD_BCB configuration
- resolve merge conflicts with latest master
- provide additional trailers from the previous version (excluding
changed patches)
- Link to v3: https://lore.kernel.org/r/20241008-android_ab_master-v3-0-f292c45a33e4@salutedevices.com
---
Dmitry Rokosov (5):
include/android_ab: move ab_select_slot() documentation to @ notation
treewide: bcb: move ab_select command to bcb subcommands
cmd: bcb: change strcmp() usage style in the do_bcb_ab_select()
cmd: bcb: introduce 'ab_dump' command to print BCB block content
common: android_ab: fix slot suffix for abc block
MAINTAINERS | 1 -
boot/android_ab.c | 116 ++++++++++++++++++++++++------
cmd/Kconfig | 14 ----
cmd/Makefile | 1 -
cmd/ab_select.c | 66 -----------------
cmd/bcb.c | 110 ++++++++++++++++++++++++++++
configs/am57xx_evm_defconfig | 1 -
configs/am57xx_hs_evm_defconfig | 1 -
configs/am57xx_hs_evm_usb_defconfig | 1 -
configs/khadas-vim3_android_ab_defconfig | 1 -
configs/khadas-vim3l_android_ab_defconfig | 1 -
configs/sandbox64_defconfig | 2 +
configs/sandbox_defconfig | 1 -
doc/android/ab.rst | 12 ++--
include/android_ab.h | 17 ++++-
include/configs/khadas-vim3_android.h | 2 +-
include/configs/khadas-vim3l_android.h | 2 +-
include/configs/meson64_android.h | 4 +-
include/configs/ti_omap5_common.h | 4 +-
test/py/tests/test_android/test_ab.py | 31 ++++++--
20 files changed, 260 insertions(+), 128 deletions(-)
---
base-commit: 5d899fc58c44fe5623e31524da2205d8597a53d1
change-id: 20241008-android_ab_master-d86d71c839ae
Best regards,
--
Dmitry Rokosov <ddrokosov at salutedevices.com>
More information about the U-Boot
mailing list