[PATCH v3 01/15] lmb: add versions of the lmb API with flags

[Sughosh Ganu]

On Mon, 14 Oct 2024 at 21:20, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Sughosh,
>
> On Sun, 13 Oct 2024 at 04:55, Sughosh Ganu <sughosh.ganu at linaro.org> wrote:
> >
> > The LMB module is to be used as a backend for allocating and freeing
> > up memory requested from other modules like EFI. These memory requests
> > are different from the typical LMB reservations in that memory
> > required by the EFI module cannot be overwritten, or re-requested. Add
> > versions of the LMB API functions with flags for allocating and
> > freeing up memory. The caller can then use these API's for specifying
> > the type of memory that is required. For now, these functions will be
> > used by the EFI memory module.
> >
> > Signed-off-by: Sughosh Ganu <sughosh.ganu at linaro.org>
> > ---
> > Changes since V2: None
> >
> >  include/lmb.h | 56 +++++++++++++++++++++++++++++++++
> >  lib/lmb.c     | 85 ++++++++++++++++++++++++++++++++++++++++++++++++++-
> >  2 files changed, 140 insertions(+), 1 deletion(-)
> >
>
> lmb_alloc_base() should call lmb_alloc_base() as well. It looks that
> you fixed that in this version?
>
> I'm not very keen on __ before functions. That is normally reserved
> for the C library. I wonder if a single one would be enough, or use an
> underscore suffix instead?

Okay, I will add a separate patch in the series to change the __ to a
single underscore. Thanks.

-sughosh

>
> Other than that:
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
>
> Regards,
> Simon