[PATCH v3 2/7] common: Tidy up how malloc() is inited

Ilias Apalodimas ilias.apalodimas at linaro.org
Tue Oct 15 21:23:56 CEST 2024


Simon,

On Tue, 15 Oct 2024 at 18:28, Simon Glass <sjg at chromium.org> wrote:
>
> Hi Ilias,
>
> On Tue, 15 Oct 2024 at 07:38, Ilias Apalodimas
> <ilias.apalodimas at linaro.org> wrote:
> >
> > Hi Simon,
> >
> > I did review enough of this series in v1 [0]. Please resend it with
> > the proper tags added. Did anything change and you dropped by r-b?
> > Because the changelog says no changes
>
> I collect tags with patman...it still doesn't see anything. Which
> patch are you referring to?

It's in my response

Thanks
/Ilias
>
> >
> > On Tue, 15 Oct 2024 at 16:33, Simon Glass <sjg at chromium.org> wrote:
> > >
> > > The call to malloc() is a bit strange. The naming of the arguments
> > > suggests that an address is passed, but in fact it is a pointer, at
> > > least in the board_init_r() function and SPL equivalent.
> > >
> > > Update it to work as described. Add a function comment as well.
> > >
> > > Note that this does adjustment does not extend into the malloc()
> > > implementation itself, apart from changing mem_malloc_init(), since
> > > there are lots of casts and pointers and integers are used
> > > interchangeably.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > Reviewed-by: Tom Rini <trini at konsulko.com>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > >  common/board_r.c  | 3 +--
> > >  common/dlmalloc.c | 8 +++++---
> > >  common/spl/spl.c  | 4 +---
> > >  include/malloc.h  | 8 ++++++++
> > >  4 files changed, 15 insertions(+), 8 deletions(-)
>
> Regards,
> Simon


More information about the U-Boot mailing list