[PATCH v2] Revert "mmc: dw_mmc: Extract FIFO data transfer into a separate routine"

Tom Rini trini at konsulko.com
Tue Oct 15 21:43:50 CEST 2024


On Tue, 08 Oct 2024 19:18:31 +0000, Jonas Karlman wrote:

> The commit 0252924ac6d4 ("mmc: dw_mmc: Extract FIFO data transfer into a
> separate routine") unintentionally changed behavior of the FIFO data
> transfer routine.
> 
> When data is read and size reaches 0 the original loop would wait on
> DWMCI_INTMSK_DTO or timeout. The remaining size to read and buf position
> is no longer tracked across dwmci_data_transfer_fifo() calls and because
> of this an extra call to fifo() and dwmci_fifo_ready() may now trigger a
> FIFO underflow timeout error and slows down FIFO reading.
> 
> [...]

Applied to u-boot/master, thanks!

-- 
Tom




More information about the U-Boot mailing list