[PATCH V2] cpu: imx8_cpu: Avoid revision to corrupt device tree

Fabio Estevam festevam at gmail.com
Thu Oct 17 14:50:22 CEST 2024


On Thu, Oct 17, 2024 at 4:08 AM Peng Fan (OSS) <peng.fan at oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan at nxp.com>
>
> U-Boot device tree is padded just after U-Boot proper.
> After the whole stuff loaded to DRAM space, the device tree
> area is conflict with BSS region before U-Boot relocation.
>
> So any write to BSS area before reloc_fdt will corrupt the
> device tree. Without the fix, there is issue that “binman_init
> failed:-2” on i.MX8MP-EVK board.
>
> Signed-off-by: Peng Fan <peng.fan at nxp.com>
> ---
>
> V2:
>  move the rev to malloc area in cpu_imx_plat
>  tested on i.MX8MP EVK

Please adapt the commit log to include this information.

This patch breaks CI. Make sure to run all your patches through CI:

https://source.denx.de/u-boot/custodians/u-boot-imx/-/jobs/920875

aarch64: + imx8qm_rom7720_a1_4G
321+WARNING 'mx8qm-ahab-container.img' not found, resulting binary is
not-functional
322+drivers/cpu/imx8_cpu.c: In function 'get_imx_rev_str':
323+drivers/cpu/imx8_cpu.c:78:17: error: 'rev' is used uninitialized
[-Werror=uninitialized]
324+ 78 | switch (rev) {
325+ | ^~~~~~
326+drivers/cpu/imx8_cpu.c:76:22: note: 'rev' was declared here
327+ 76 | char rev;
328+ | ^~~
329+cc1: all warnings being treated as errors

I am getting too much extra work to process the patches from NXP folks
and I am not happy with it.


More information about the U-Boot mailing list