[PATCH] usb: dwc3-generic: use DR_MODE_OTG when dr_mode isn't specified

[Neil Armstrong]

On 17/10/2024 15:52, Marek Vasut wrote:
> On 10/17/24 1:07 PM, Caleb Connolly wrote:
>>
>>
>> On 16/10/2024 10:26, Neil Armstrong via groups.io wrote:
>>> The USB DRD bindingsa at [1] are clear, if not specified the dr_mode
>>> property defaults to otg, and this is how Linux behaves.
>>
>> I guess this is (kind of?) a subset of
>>
>> https://lore.kernel.org/u-boot/20240621021135.1600847-2- caleb.connolly at linaro.org/

Yes and no, it should be on top of mine

>>
>> I need to respin that one...
> 
> It would be good to include that information in the commit message ...

Will do

> 
>>> A cleanup is ongoing on the Linux Device Trees to remove dr_mode when
>>> set to "otg", so take this in account and do not fail anymore when
>>> dr_mode isn't specified in the glue or dwc3 node.
>>
>> Definitely an improvement over the status quo heh
>>
>> Reviewed-by: Caleb Connolly <caleb.connolly at linaro.org>
> ... and eventually synchronize the DWC3 driver with current Linux kernel state of it.

Well, this behavior should've been in U-Boot since the beginning!

But yeah, it's should be done and it's another subject because it would
impact a lot of boards.

Neil

>