[PATCH 1/4] virtio: blk: introduce virtio-block erase support

[Simon Glass]

Hi Dmitrii,

Thank you for the patch.

I'm not the virtio maintainer in U-Boot:

/mnt/work/upstream/u-boot/ $ ./scripts/get_maintainer.pl drivers/virtio/
Bin Meng <bmeng.cn at gmail.com> (maintainer:VirtIO)
[...]

I've added Bin to the Cc list, please include him if you re-submit.

On mer., mars 06, 2024 at 18:59, Dmitrii Merkurev <dimorinny at google.com> wrote:

> Co-developed-by: Cody Schuffelen <schuffelen at google.com>
> Signed-off-by: Cody Schuffelen <schuffelen at google.com>
> Signed-off-by: Dmitrii Merkurev <dimorinny at google.com>
> Cc: Tuomas Tynkkynen <tuomas.tynkkynen at iki.fi>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Mattijs Korpershoek <mkorpershoek at baylibre.com>
> Cc: Ying-Chun Liu (PaulLiu) <paul.liu at linaro.org>

I'm not super familiar with virtio, so I've not reviewed this.

However, I tested the sandbox unit tests:

uboot at db354723333a:/mnt/work/upstream/u-boot$ ./u-boot -T -c "ut dm virtio*"
Bloblist at b000 not found (err=-2)
sandbox_serial serial: pinctrl_select_state_full:
uclass_get_device_by_phandle_id: err=-19


U-Boot 2024.04-00137-g075feb52299 (Apr 05 2024 - 07:12:35 +0000)

Reset Status: WARM Reset Status: COLD
Model: sandbox
DRAM:  256 MiB
[nvmxip-qspi1 at 08000000]: the block device blk#2 ready for use
[nvmxip-qspi2 at 08200000]: the block device blk#2 ready for use
Core:  286 devices, 101 uclasses, devicetree: board
WDT:   Not starting wdt-gpio-toggle
WDT:   Not starting wdt-gpio-level
WDT:   Not starting wdt at 0
NAND:  4100 MiB
MMC:   mmc2: 2 (SD), mmc1: 1 (SD), mmc0: 0 (SD)
Loading Environment from nowhere... OK
In:    serial,cros-ec-keyb,usbkbd
Out:   serial,vidconsole
Err:   serial,vidconsole
Model: sandbox
Net:   eth0: eth at 10002000, eth5: eth at 10003000, eth3: sbe5, eth6:
eth at 10004000, eth8: phy-test-eth, eth4: dsa-test-eth, eth2: lan0,
eth7: lan1
Test: dm_test_virtio_all_ops: virtio_device.c
Test: dm_test_virtio_all_ops: virtio_device.c (flat tree)
Test: dm_test_virtio_base: virtio_device.c
Test: dm_test_virtio_base: virtio_device.c (flat tree)
Test: dm_test_virtio_missing_ops: virtio.c
Test: dm_test_virtio_missing_ops: virtio.c (flat tree)
Test: dm_test_virtio_remove: virtio_device.c
Test: dm_test_virtio_remove: virtio_device.c (flat tree)
Test: dm_test_virtio_ring: virtio_device.c
Test: dm_test_virtio_ring: virtio_device.c (flat tree)
Test: dm_test_virtio_rng_check_len: virtio_rng.c
Test: dm_test_virtio_rng_check_len: virtio_rng.c (flat tree)
Failures: 0

Tested-by: Mattijs Korpershoek <mkorpershoek at baylibre.com> # sandbox

> ---
>  drivers/virtio/virtio_blk.c | 91 +++++++++++++++++++++++++++++++------
>  drivers/virtio/virtio_blk.h | 47 +++++++++++++++++++
>  2 files changed, 124 insertions(+), 14 deletions(-)
>
Applied to u-boot-dm, thanks!