[PATCH v3 4/8] sunxi: Add a bootmeth for FEL

[Simon Glass]

Hi Andre,

On Wed, 2 Oct 2024 at 12:03, Andre Przywara <andre.przywara at arm.com> wrote:
>
> Hi Simon,
>
> On 01/09/2024 23:27, Simon Glass wrote:
> > Add support for booting from a script loaded over FEL. This mirrors the
> > bootcmd_fel provided by distro boot.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > Reviewed-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
> > ---
> >
> > (no changes since v2)
> >
> > Changes in v2:
> > - Put the FEL bootmeth before all other global bootmeths
> >
> >   boot/Kconfig        | 14 ++++++++
> >   boot/Makefile       |  1 +
> >   boot/bootmeth_fel.c | 81 +++++++++++++++++++++++++++++++++++++++++++++
> >   3 files changed, 96 insertions(+)
> >   create mode 100644 boot/bootmeth_fel.c
> >
> > diff --git a/boot/Kconfig b/boot/Kconfig
> > index 291919ea1ef..7d6e819bde6 100644
> > --- a/boot/Kconfig
> > +++ b/boot/Kconfig
> > @@ -585,6 +585,20 @@ config BOOTMETH_EFI_BOOTMGR
> >         the EFI binary to be launched is determined. To set the EFI variables
> >         use the eficonfig command.
> >
> > +config BOOTMETH_FEL
> > +     bool "Bootdev support for Sunxi FEL"
> > +     depends on ARCH_SUNXI
> > +     default y
> > +     help
> > +       Enables support for booting over USB on a Sunxi device. This uses
> > +       the FEL protocol and obtains the script address from the
> > +       'fel_scriptaddr' environment variable.
>
> This is not quite accurate, can you please change this to something like
> (feel free to amend):
> =======
> Enables support for executing an explicit boot script uploaded before
> via the USB FEL protocol. The 'fel_scriptaddr' environment variable
> holds the address of this script, taken from the SPL header.
> =======
>
> (The flow is: The sunxi-fel tool detects an mkimage script file among
> its command line parameters, and amends the uploaded SPL header to store
> its upload address. U-Boot proper will detect the address in the SPL
> header, and sets the fel_scriptaddr variable.)
>
> The actual code looks alright, and it seems to work (TM).
>
> Just one thing I noticed:
> ....
> Hit any key to stop autoboot:  0
> ** Booting bootflow '<NULL>' with fel
> Hello from FEL script!
>
> Is this <NULL> expected? Shall there be anything better in there?

Oh, I'll give it a name.

Thanks for reviewing.

Regards,
SImon