[PATCH 1/1] sandbox: add bootmethod EFI boot-manager

[Heinrich Schuchardt]

On 10/18/24 01:23, Simon Glass wrote:
> Hi Heinrich,
> 
> On Fri, 11 Oct 2024 at 08:27, Mattijs Korpershoek
> <mkorpershoek at baylibre.com> wrote:
>>
>> Hi Heinrich,
>>
>> Thank you for the patch.
>>
>> On mer., oct. 09, 2024 at 00:32, Heinrich Schuchardt <heinrich.schuchardt at canonical.com> wrote:
>>
>>> The EFI boot-manager is the default method to boot EFI binaries.
>>> We should be able to use it on the Sandbox.
>>>
>>> * Enable EFI boot-manager bootmethod on the sandbox.
>>> * Adjust unit tests to reflect the additional boot method.
>>>
>>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
>>
>> Reviewed-by: Mattijs Korpershoek <mkorpershoek at baylibre.com>
>>
>>> ---
>>>   arch/sandbox/dts/test.dts |  4 ++++
>>>   test/boot/bootmeth.c      | 28 +++++++++++++++++-----------
>>>   2 files changed, 21 insertions(+), 11 deletions(-)
>>>
> 
> This produces the following output on sandbox, for me:
> 
> => bootfl scan
> efi_set_blk_dev_to_system_partition() No EFI system partition
> efi_set_blk_dev_to_system_partition() No EFI system partition
>       efi_var_to_file() Failed to persist EFI variables
> efi_set_blk_dev_to_system_partition() No EFI system partition
>       efi_var_to_file() Failed to persist EFI variables
> efi_set_blk_dev_to_system_partition() No EFI system partition
>       efi_var_to_file() Failed to persist EFI variables
> efi_set_blk_dev_to_system_partition() No EFI system partition
>       efi_var_to_file() Failed to persist EFI variables
> efi_set_blk_dev_to_system_partition() No EFI system partition
>       efi_var_to_file() Failed to persist EFI variables
> efi_set_blk_dev_to_system_partition() No EFI system partition
>       efi_var_to_file() Failed to persist EFI variables
> efi_set_blk_dev_to_system_partition() No EFI system partition
>       efi_var_to_file() Failed to persist EFI variables
> 
> Perhaps we need to make this option, e.g. with a 'bootstd' command to enable it?

These messages only appear if you have no ESP on a connected block 
device and store EFI variables on disk. For each block device a BOOT#### 
variable is created.

Instead of changing this patch we should reduce the noisiness.

For a user it should be sufficient to read once that EFI variables 
cannot be persisted due to a missing ESP.

Best regards

Heinrich