[PATCH 15/34] image: Add a new type for extlinux

Tom Rini trini at konsulko.com
Fri Oct 18 05:14:55 CEST 2024


On Thu, Oct 17, 2024 at 05:23:54PM -0600, Simon Glass wrote:

> Add an image type for the extlinux.cfg file, which U-Boot supports
> reading.
> 
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
> 
>  boot/image.c    | 1 +
>  include/image.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/boot/image.c b/boot/image.c
> index abac254e026..cf16fb7fbf7 100644
> --- a/boot/image.c
> +++ b/boot/image.c
> @@ -183,6 +183,7 @@ static const table_entry_t uimage_type[] = {
>  	{	IH_TYPE_FDT_LEGACY, "fdt_legacy", "legacy Image with Flat Device Tree ", },
>  	{	IH_TYPE_RENESAS_SPKG, "spkgimage", "Renesas SPKG Image" },
>  	{	IH_TYPE_STARFIVE_SPL, "sfspl", "StarFive SPL Image" },
> +	{	IH_TYPE_EXTLINUX_CFG, "extlinux_cfg", "Extlinux configuration" },
>  	{	-1,		    "",		  "",			},
>  };

This whole part of the series feels like we're abusing IH_TYPE_ far past
what it's used for. Especially the command line string one. It seems
like the main use is to be able to later on print something human
friendly. Please try and figure out some other way to do that. Thanks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241017/0da24769/attachment.sig>


More information about the U-Boot mailing list