[PATCH 1/1] efi_loader: add missing lf in error message

Simon Glass sjg at chromium.org
Fri Oct 18 16:52:36 CEST 2024


On Thu, 17 Oct 2024 at 12:19, Ilias Apalodimas
<ilias.apalodimas at linaro.org> wrote:
>
> On Thu, 17 Oct 2024 at 21:05, Heinrich Schuchardt
> <heinrich.schuchardt at canonical.com> wrote:
> >
> > Messages written with log_err() should terminate with a linefeed.
> >
> > Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> > ---
> >  lib/efi_loader/efi_memory.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/efi_loader/efi_memory.c b/lib/efi_loader/efi_memory.c
> > index b63b5cca71e..3d742fa1915 100644
> > --- a/lib/efi_loader/efi_memory.c
> > +++ b/lib/efi_loader/efi_memory.c
> > @@ -652,7 +652,7 @@ void *efi_alloc(size_t size)
> >
> >         if (efi_allocate_pool(EFI_BOOT_SERVICES_DATA, size, &buf) !=
> >             EFI_SUCCESS) {
> > -               log_err("out of memory");
> > +               log_err("out of memory\n");
> >                 return NULL;
> >         }
> >         memset(buf, 0, size);
> > --
> > 2.45.2
> >\
>
> Reviewed-by: Ilias Apalodimas <ilias.apalodimas at linaro.org>

Reviewed-by: Simon Glass <sjg at chromium.org>

I had the same patch locally :-)


More information about the U-Boot mailing list