[PATCH 2/3] x86: coreboot: Add timestamps from coreboot to bootstage

[Jonas Karlman]

Hi Simon,

On 2024-10-18 16:59, Simon Glass wrote:
> Hi Jonas,
> 
> On Fri, 18 Oct 2024 at 01:44, Jonas Karlman <jonas at kwiboo.se> wrote:
>>
>> Hi Simon,
>>
>> On 2024-10-18 01:12, Simon Glass wrote:
>>> Receiving timestamps from coreboot was unceremoniously dropped some time
>>> ago. Add it back.
>>>
>>> Signed-off-by: Simon Glass <sjg at chromium.org>
>>> Fixes: 8ad01ce36f7 ("x86: Remove x86 specific GD flags as they are...")
>>> ---
>>>
>>>  arch/x86/cpu/coreboot/coreboot.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> Applied to u-boot-dm, thanks!
>>
>> I was under the impression that you would rework this to prepend the
>> coreboot bootstage records instead of adding the preceding coreboot
>> records in the middle of existing U-Boot records.
>>
>> Or did I misinterpret your response [1] to my "bootstage: Do not sort
>> records" patch [2] and you instead wanted me to do this?
> 
> I decided to worry about this later. There is a coreboot update as
> well in this lot of patches. Once that is applied I have some more
> pending patches and I will take a look at this.
> 
> I sort-of agree that sorting shouldn't be necessary...it's just that
> with the boot sequence getting so complicated these days, I'm not
> sure. But let's go with unsorted and worry about it later when we have
> other cases (i.e. other than a prior stage) to worry about.

Does that mean you will merge my patch [2] to remove the sorting? It is
currently marked as 'Changes Requested', yet there is no request to
change anything. Only a request to insert the coreboot records in
correct order, something that is more related to this patch in my mind.

Regards,
Jonas

> 
> Regards,
> Simon
> 
> 
> 
>>
>> [1] https://lore.kernel.org/u-boot/CAFLszTjz9dX2UzUHgbmsr2no4seK07oo2PC++hS2t7CP7z8khA@mail.gmail.com/
>> [2] https://patchwork.ozlabs.org/project/uboot/patch/20240803124149.2916030-3-jonas@kwiboo.se/