[PATCH 1/1] efi_loader: fix CONFIG_EFI_HTTP dependencies

Simon Glass sjg at chromium.org
Sat Oct 19 13:49:55 CEST 2024


Hi Heinrich,

On Sat, 19 Oct 2024 at 05:00, Heinrich Schuchardt
<heinrich.schuchardt at canonical.com> wrote:
>
> CONFIG_CMD_DNS and CONFIG_CMD_WGET depend on CONFIG_CMD_NET.
> CONFIG_CMD_NET depends on CONFIG_NET or CONFIG_NET_LWIP.
>
> We shall only enable CONFIG_EFI_HTTP if there is network support.
> We have to select CONFIG_CMD_NET.
>
> Fixes: d7d07a8b508b ("efi_loader: support boot from URI device path")
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt at canonical.com>
> ---
>  lib/efi_loader/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
> index 69b2c9360d8..066f0ca0da7 100644
> --- a/lib/efi_loader/Kconfig
> +++ b/lib/efi_loader/Kconfig
> @@ -545,6 +545,8 @@ config EFI_BOOTMGR
>
>  config EFI_HTTP_BOOT
>         bool "EFI HTTP Boot support"
> +       depends on NET || NET_LWIP
> +       select CMD_NET
>         select CMD_DNS
>         select CMD_WGET
>         select BLKMAP
> --
> 2.45.2
>

At least conceptually, we should be able to get a file without needing
commands enabled. If we have to do this today, that's fine, but it is
something to improve.

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon


More information about the U-Boot mailing list