[PATCH] CI: Add a test for building without CMDLINE
Tom Rini
trini at konsulko.com
Mon Oct 21 18:49:58 CEST 2024
On Mon, Oct 21, 2024 at 06:32:18PM +0200, Simon Glass wrote:
> Hi Tom,
>
> On Mon, Oct 21, 2024, 16:33 Tom Rini <trini at konsulko.com> wrote:
> >
> > On Mon, Oct 21, 2024 at 03:44:49PM +0200, Simon Glass wrote:
> >
> > > Something this breaks, so add a test to keep it working. Since sandbox
> > > enables a lot of options, it is a good board to use.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> > > ---
> > >
> > > .azure-pipelines.yml | 8 ++++++++
> > > .gitlab-ci.yml | 11 +++++++++++
> > > 2 files changed, 19 insertions(+)
> >
> > I don't like this because "sandbox" is one of the longest run-time
> > build options due to all of the tests it runs. And given how we break
> > down the jobs this will make a further bottleneck. Can we just disable
> > CMDLINE in one of the existing sandbox defconfigs instead please?
> > Perhaps sandbox_spl since that only does SPL related pytests?
>
> Actually we do boot into U-Boot proper as some tests need to check
> that SPL did the right thing.
>
> Note that this patch doesn't run any tests at all. It just tries to
> build sandbox without CMDLINE
Is there no existing thing we can put this in? And have we had another
problem with CMDLINE=n ? It's not cheap (wall clock) to add another
stage, especially in Azure, I'd really rather figure some way to bundle
this in with what we already do. Heck, following on with
qemu_arm64_lwip_defconfig I'd rather just add
sandbox_no_cmdline_defconfig and use #include so that it's just a few
lines of defconfig anyhow, but merged in with existing builds.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241021/cf1cdc99/attachment.sig>
More information about the U-Boot
mailing list