[PATCH 10/10] tests: update smbios pytest

Tom Rini trini at konsulko.com
Mon Oct 21 19:23:58 CEST 2024


On Mon, Oct 21, 2024 at 11:23:05AM -0400, Raymond Mao wrote:
> Hi Tom,
> 
> On Mon, 19 Aug 2024 at 18:19, Tom Rini <trini at konsulko.com> wrote:
> 
> > On Fri, Aug 16, 2024 at 08:46:53AM -0700, Raymond Mao wrote:
> > > Update the expected test result to align with the smbios library changes.
> > >
> > > Signed-off-by: Raymond Mao <raymond.mao at linaro.org>
> > > ---
> > >  test/py/tests/test_smbios.py | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/test/py/tests/test_smbios.py b/test/py/tests/test_smbios.py
> > > index 82b0b689830..ffa4ea795ec 100644
> > > --- a/test/py/tests/test_smbios.py
> > > +++ b/test/py/tests/test_smbios.py
> > > @@ -32,7 +32,7 @@ def test_cmd_smbios_sandbox(u_boot_console):
> > >      """Run the smbios command on the sandbox"""
> > >      output = u_boot_console.run_command('smbios')
> > >      assert 'DMI type 0,' in output
> > > -    assert 'String 1: U-Boot' in output
> > > +    assert 'Vendor: U-Boot' in output
> > >      assert 'DMI type 1,' in output
> > >      assert 'Manufacturer: sandbox' in output
> > >      assert 'DMI type 2,' in output
> >
> > This needs to be done with the change, not by itself.
> >
> Sorry but I didn't get what you mean... but shall I exclude this one from
> the series?

What I mean is that the series should be bisect'able within the pytest
framework too and not just build time. So the commit that breaks the
test is where the test should be fixed.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20241021/72ede1f3/attachment.sig>


More information about the U-Boot mailing list